Skip to content

[https://nvbugs/6541322][fix] Unwaive fixed test - #17131

Merged
2ez4bz merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-nvbug-6541322
Aug 1, 2026
Merged

[https://nvbugs/6541322][fix] Unwaive fixed test#17131
2ez4bz merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-nvbug-6541322

Conversation

@2ez4bz

@2ez4bz 2ez4bz commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • The PR adds a Mamba-specific zero-token constraint for hybrid-model state-slot sizing when avg_seq_len is unset.
  • The constraint preserves one SSM state slot for each resident or dummy sequence.
  • The targeted constraint avoids changing the initial pool ratio and prevents regressions in Gemma 4 pool sizing and performance.
  • TEP and DEP sizing use the real allocator.
  • The change does not restore the generic warmup constraint, which would regress existing pool sizing.
  • The DEP test waiver was removed with its associated bug reference.
  • No public or exported entities changed.

QA Engineer Review

  • Modified test-list file: tests/integration/test_lists/waives.txt.
  • Removed waiver: accuracy/test_llm_api_pytorch.py::TestQwen3NextInstruct::test_bf16_4gpu[dep4].
  • No test code changed.
  • CBTS coverage data is unavailable.

Verdict: needs follow-up

Description

Commit 7f7dccf added an explicit SSM min-slot floor which fixes the
regression introduced by a1e5771.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The integration test waiver for TestQwen3NextInstruct::test_bf16_4gpu[dep4] was removed from waives.txt.

Changes

Cohort / File(s) Summary
Integration test waiver
tests/integration/test_lists/waives.txt
Removes the skipped test entry and its associated bug reference.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: bowenfu, lowsfer, eopxd

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the NVBugs fix and the removal of the waiver for the repaired test.
Description check ✅ Passed The description explains the fix and includes the checklist, but the Test Coverage section is empty.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/unittest/_torch/executor/test_mamba_cache_manager.py`:
- Around line 1311-1313: Update
test_v2_hybrid_default_preserves_live_state_slot_floor by annotating
num_reserved_dummy_slots and expected_num_slots as int and the function return
type as None.
- Around line 1305-1355: Add test-list entries for
test_v2_hybrid_default_preserves_live_state_slot_floor and
test_v2_hybrid_typical_batch_splits_capacity_across_ssm_states_and_dummies in
the appropriate test-db and/or qa list under tests/integration/test_lists.
Ensure both newly covered tests are registered using the existing list format.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e356549f-f013-4718-bfec-95dd8b5af9ad

📥 Commits

Reviewing files that changed from the base of the PR and between 066bab1 and 5337896.

📒 Files selected for processing (3)
  • tensorrt_llm/_torch/pyexecutor/mamba_cache_manager.py
  • tests/integration/test_lists/waives.txt
  • tests/unittest/_torch/executor/test_mamba_cache_manager.py
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/unittest/_torch/executor/test_mamba_cache_manager.py Outdated
Comment thread tests/unittest/_torch/executor/test_mamba_cache_manager.py Outdated
Commit 7f7dccf added an explicit SSM min-slot floor which fixes the
regression introduced by a1e5771.

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
@2ez4bz
2ez4bz force-pushed the dev-nvbug-6541322 branch from 5337896 to cd5b4e4 Compare July 31, 2026 17:31
@2ez4bz 2ez4bz changed the title [https://nvbugs/6541322][fix] Preserve Mamba state slot floor [https://nvbugs/6541322][fix] Unwaive fixed test Jul 31, 2026
@2ez4bz

2ez4bz commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63091 [ run ] triggered by Bot. Commit: cd5b4e4 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63091 [ run ] completed with state SUCCESS. Commit: cd5b4e4
/LLM/main/L0_MergeRequest_PR pipeline #51180 completed with status: 'SUCCESS'

CI Report

Link to invocation

@2ez4bz
2ez4bz enabled auto-merge (squash) July 31, 2026 19:28
@2ez4bz

2ez4bz commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

/bot help

@github-actions

Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Supports wildcard * for pattern matching (e.g., "*PerfSanity*" matches all stages containing PerfSanity). Examples: "A10-PyTorch-1, xxx", "PerfSanity". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label. Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline. Requires the ci: post-merge approved PR label applied by an active member of NVIDIA/trt-llm-ci-approvers. The approval label remains in place when new commits are pushed.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Supports wildcard * for pattern matching. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx", --extra-stage "Post-Merge". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label.

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@BowenFu BowenFu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root cause checks out: a1e5771 dropped the default warmup constraints when `avg_seq_len` is unset, and 7f7dccf restores an explicit floor (`mamba_cache_manager.py`, `ssm_floor_slots = _max_resident_sequences() + _num_reserved_dummy_slots`) — that is the invariant that was missing, not a workaround.

Two notes, neither blocking:

  • This test is post-merge-only (`l0_dgx_h200.yml:42`, `l0_gb200_multi_gpus.yml:86`), so the green `/bot run` here did not execute it. What covers the gap is your verification on main plus the repair-bot run on HEAD recorded in nvbugs/6541322.
  • #17150 removes the identical line. Worth closing one of the two before either lands.

@2ez4bz
2ez4bz merged commit b136596 into NVIDIA:main Aug 1, 2026
17 checks passed
yuanjingx87 pushed a commit that referenced this pull request Aug 1, 2026
Commit 7f7dccf added an explicit SSM min-slot floor which fixes the
regression introduced by a1e5771.

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants