[NVBUG-6448152][test] replay pre-PR15356 native admission - #17141
[NVBUG-6448152][test] replay pre-PR15356 native admission#17141chienchunhung wants to merge 13 commits into
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Yihan Wang <yihwang@nvidia.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 6fc7f33)
…sensus factor Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 9c8bf59)
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 4b182f1)
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
|
The old CI head is preserved on |
|
/bot run --disable-fail-fast --stage-list "GB300-12_GPUs-3_Nodes-PyTorch-Disagg-PerfSanity-CTX1-NODE1-GPU4-GEN1-NODE2-GPU8-Post-Merge-1" |
|
PR_Github #63160 [ run ] triggered by Bot. Commit: |
|
PR_Github #63160 [ run ] completed with state
|
|
Terminal result for the exact native first-admission replay:
Strict interpretation: this run confirms no recovery, but the replayed first-admission decision was nonbinding for this measured request sequence, so it neither implicates nor rules out that decision under a workload that forces divergence. The CI performance-threshold failure is the expected consequence of remaining near the known slow baseline, not a functional failure. Closing this TEST ONLY draft unmerged. The diagnostic branch is preserved. |
Purpose
TEST ONLY — DO NOT REVIEW OR MERGE.
This draft performs the requested complete pre-PR #15356 replay of the native
GUARANTEED_NO_EVICTfirst admission gate on the exact frozen slow baseline. It tests every transfer-related first-gate accounting change together while leaving the PR #15356 Python transport-budget gate enabled at multiplier 1.The causal treatment is the signed first parent:
dd4a7ac2992f2b02dce381ce4e630c4ba419943633833104032ad6157e4aba6150fe0cc9552de9d64025abdfa3881e695f1565c5b11808e18a74bd083cd8c43e4c5a0b219fe8754c08e3a2afe08a9f3c0d791d1001942c3b0ea98dcc04bbf574682958b4235ac8ead89080ac516acdadThe current CI head
1c39d556886c93a4646a0679faa3559b64ddbcb8adds latest main946f9c5fbf0f30855533b9b3baa2a2a621b1742cas an ancestry-only second parent on preserved prior CI head6cc12437167c941222231d37c2e25d6adbb07c9c. Its tree remains byte-identical to the treatment tree. Review and interpret only the baseline-to-treatment causal diff. This ancestry vehicle must never merge.Single treatment
For
GUARANTEED_NO_EVICT, aDISAGG_GENERATION_TRANS_IN_PROGRESSrequest is skipped before all four pre-PR #15356 accounting decisions:maxNumRequestsslots;All non-transfer requests retain the original scheduler order and checks.
STATICandMAX_UTILIZATIONare unchanged. Transfer-only requests remain non-compute-scheduled.The downstream Python
DisaggTransferAdmissionControlleris behaviorally unchanged at exact multiplier 1 /max_tokens_in_buffer=131104: normal selection, reverts, and wait decisions remain active. Added Python code observes its decisions only.Exercised discriminator
The treatment path is primary. A read-only current-behavior shadow runs only on transfer-active iterations and only until the first exact ordered candidate divergence on each scheduling rank; it is absent on idle iterations and permanently disabled after divergence. Immediate ID-free markers and shutdown summaries split:
pre_only_disagg_init;pre_only_ready_generation;pre_only_other.The shadow result must be an ordered subset of the treatment result. This bounds instrumentation overhead while proving the treatment changed a reachable decision.
Frozen workload and acceptance
The exact historical C++/NIXL DeepSeek-R1 128K/8K workload remains fixed: GB300, three nodes/twelve GPUs, CTX PP4, GEN DEP8, 512 total requests, original selector/image/runtime/topology, mode2/cancellation-off, and multiplier-1 second gate.
A valid result requires:
b_is_valid=true, clean CTX/GEN/disaggregated shutdown;transfer_active > 0and an exactevent=exercisedold-versus-treatment divergence on every such rank;Recovery toward the exact pre-PR parent result (1515.84 output tok/s; slow child 799.73) with exercised evidence implicates the first-gate transfer-accounting bundle. Near 800 tok/s with a ready-generation divergence rules the bundle down as sufficient. Init-only divergence followed by unchanged Python deferral proves second-gate masking. Missing per-rank reachability or required functional evidence censors the result.
Formatting, configured hooks, DCO, diff checks, Python compilation, Python 3.13 test-list checks, and independent causal review passed. Focused pytest is blocked only by unavailable
transformers; no local C++ build tree exists, so automatic compile gates must pass before one exact trigger.The scarce GB300 trigger is intentionally withheld until the higher-priority PR #16645 versus rebased-main comparison has secured its matched runs.