Skip to content

[None][fix] Mark prototype status for API flag index_share_for_mtp_iteration - #17149

Open
nvxuanyuc wants to merge 1 commit into
NVIDIA:mainfrom
nvxuanyuc:dsa_mtp_indexcache
Open

[None][fix] Mark prototype status for API flag index_share_for_mtp_iteration#17149
nvxuanyuc wants to merge 1 commit into
NVIDIA:mainfrom
nvxuanyuc:dsa_mtp_indexcache

Conversation

@nvxuanyuc

@nvxuanyuc nvxuanyuc commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Updated DeepSeekSparseAttentionConfig.index_share_for_mtp_iteration metadata to status="prototype".
  • The change correctly scopes the API status update to the intended field.
  • No runtime behavior, performance, error handling, or configuration values changed.
  • No test-list or test-file changes were made.
  • Test coverage is N/A.

QA Engineer Review

No test changes.

Description

Fix for #15806. Mark prototype status for API flag index_share_for_mtp_iteration.

Test Coverage

N/A

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…eration

Signed-off-by: Xuanyu Chen <xuanyuc@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f725449f-6a78-4feb-acd0-75aede28b128

📥 Commits

Reviewing files that changed from the base of the PR and between 946f9c5 and fe09aed.

📒 Files selected for processing (1)
  • tensorrt_llm/llmapi/llm_args.py

Walkthrough

The change marks DeepSeekSparseAttentionConfig.index_share_for_mtp_iteration as a prototype configuration field through its metadata.

Changes

Prototype configuration metadata

Layer / File(s) Summary
Mark configuration field as prototype
tensorrt_llm/llmapi/llm_args.py
Adds status="prototype" to the index_share_for_mtp_iteration field metadata.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix and the API flag whose prototype status changed.
Description check ✅ Passed The description explains the change and lists test coverage as not applicable for this metadata-only update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@nvxuanyuc nvxuanyuc added the api-compatible Accepted LLM API contract change that is backwards-compatible label Aug 1, 2026
@nvxuanyuc

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63155 [ run ] triggered by Bot. Commit: fe09aed Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63155 [ run ] completed with state FAILURE. Commit: fe09aed
/LLM/main/L0_MergeRequest_PR pipeline #51238 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-compatible Accepted LLM API contract change that is backwards-compatible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants