Skip to content

[TRTLLM-14772][doc] Add sudo to apt prerequisites - #17161

Open
bobboli wants to merge 1 commit into
NVIDIA:mainfrom
bobboli:fix/nvbug-6533915-sudo-apt
Open

[TRTLLM-14772][doc] Add sudo to apt prerequisites#17161
bobboli wants to merge 1 commit into
NVIDIA:mainfrom
bobboli:fix/nvbug-6533915-sudo-apt

Conversation

@bobboli

@bobboli bobboli commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Description

Add sudo to both apt-get invocations in the build-from-source prerequisites so the documented command works for the default non-root user.

Fixes NVBug 6533915.

Test Coverage

  • pre-commit run --files docs/source/installation/build-from-source.md
  • git diff --check

PR Checklist

  • Reviewed the checklist in the pull request template; the applicable requirements are satisfied.

Dev Engineer Review

  • Updated both apt-get prerequisite commands in docs/source/installation/build-from-source.md to use sudo.
  • The change supports the default non-root user.
  • The documentation change is consistent and has no API, performance, or regression impact.
  • Pre-commit checks and git diff --check passed.

QA Engineer Review

No test changes.

Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
@bobboli
bobboli requested a review from a team as a code owner August 1, 2026 14:16
@bobboli
bobboli requested review from chang-l and kaiyux August 1, 2026 14:16
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 66378bf0-3dbc-41de-8617-6d4d997f832f

📥 Commits

Reviewing files that changed from the base of the PR and between fdf7bd5 and fbd8d53.

📒 Files selected for processing (1)
  • docs/source/installation/build-from-source.md

Walkthrough

The build-from-source documentation now uses sudo for both apt-get operations in the Git and Git LFS installation command.

Changes

Installation documentation

Layer / File(s) Summary
Use sudo for apt-get operations
docs/source/installation/build-from-source.md
The Git and Git LFS installation command now uses sudo for both apt-get operations.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required ticket and type format and clearly describes the documentation change.
Description check ✅ Passed The description includes the issue, solution, validation steps, and a completed checklist relevant to this documentation change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bobboli
bobboli enabled auto-merge (squash) August 2, 2026 08:47
@bobboli

bobboli commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63266 [ run ] triggered by Bot. Commit: fbd8d53 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63266 [ run ] completed with state DISABLED
Pipeline is freezed and top-1 instance is under maintenance. For urgent request, contact Yiteng Niu

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants