Use a temp directory for CMake build - #3254
Conversation
Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
|
/te-ci |
|
The failing job is a scheduling timeout for a GPU-specific runner that was having some issues next week. Going to assume that it's unrelated. |
|
/te-ci |
Greptile SummaryThe PR isolates non-editable CMake extension builds in automatically cleaned temporary directories while retaining persistent incremental builds for editable installs or when
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "Add fallback to exisiting build dir beha..." | Re-trigger Greptile |
|
Hmm, this has a potential of being a little disruptive (especially considering that the time needed to build TE is quite long). Could there maybe be some middle ground where e.g. the |
…nstall Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
|
Good catch - added |
|
/te-ci |
Description
CMake currently always uses
./build/cmakeas a build directory whenNVTE_CMAKE_BUILD_DIRis not set. This causes a couple of issues:This creates a temporary directory and cleans it up afterwards. Note: this makes it harder to inspect the build directory, because it will now be cleaned up after every run. For this use case I would recommend setting `NVTE_CMAKE_BUILD_DIR="${PWD}/build/cmake" to retain the current behavior. As a result of moving to a temp directory, object files will now not be reused between builds as well.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: