Add env overloads for Select::* in place algorithms#8018
Merged
gonidelis merged 2 commits intoNVIDIA:mainfrom Mar 19, 2026
Merged
Add env overloads for Select::* in place algorithms#8018gonidelis merged 2 commits intoNVIDIA:mainfrom
gonidelis merged 2 commits intoNVIDIA:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
miscco
reviewed
Mar 13, 2026
| REQUIRE(data == expected_output); | ||
| } | ||
|
|
||
| C2H_TEST("cub::DeviceSelect::If in-place accepts env with stream", "[select][env]") |
Contributor
There was a problem hiding this comment.
We dopcument:
//! - | The range
[d_out, d_out + *d_num_selected_out)shall not overlap
//! |[d_in, d_in + num_items)nord_num_selected_outin any way.
Is that actually valid? Asking for someone that needs that
Contributor
There was a problem hiding this comment.
cub::DeviceSelect::If has two overloads, an in-place one and one with separate source and destination iterators.
NaderAlAwar
approved these changes
Mar 19, 2026
Contributor
NaderAlAwar
left a comment
NaderAlAwar
left a comment
There was a problem hiding this comment.
Left a few comments to improve documentation
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 20m: Pass: 100%/249 | Total: 5d 04h | Max: 2h 19m | Hits: 93%/157552See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in-place
DeviceSelectenvironment overloadsfixes #7945