[cudax] Implement replicate and join for path_builder#8021
Open
pciolkosz wants to merge 5 commits intoNVIDIA:mainfrom
Open
[cudax] Implement replicate and join for path_builder#8021pciolkosz wants to merge 5 commits intoNVIDIA:mainfrom
pciolkosz wants to merge 5 commits intoNVIDIA:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
davebayer
reviewed
Mar 13, 2026
| //! \brief Add a range of dependency nodes to this path builder. | ||
| //! \param __deps The dependency node range to add. | ||
| template <size_t _Extent> | ||
| _CCCL_HOST_API void depends_on(::cuda::std::span<const cudaGraphNode_t, _Extent> __deps) |
Contributor
There was a problem hiding this comment.
Shouldn't this take a range instead of span?
This comment has been minimized.
This comment has been minimized.
pciolkosz
force-pushed
the
replicate_join_for_path_builder
branch
from
92f396b to
3653eca
Compare
pciolkosz
added
the
pre-commit.ci autofix
pre-commit-ci
Bot
removed
the
pre-commit.ci autofix
Contributor
Contributor
Author
|
/ok to test 9862734 |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test c76f06c |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test f29fab6 |
Contributor
🥳 CI Workflow Results🟩 Finished in 20m 46s: Pass: 100%/48 | Total: 6h 50m | Max: 20m 29s | Hits: 92%/23649See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #8014 implements
replicateandjoinfor streams, this one does that forpath_builder. The semantics is mostly the same as for streams,replicatecreates a requested number of path builders in the same graph,replicate_prependdoes the same but also add the input one to the output.joingathers all dependencies from one set of path builders and adds them to another set of path builders.One observation was that we don't try to avoid duplicate dependencies in graph APIs and we possibly should take a look into that.
joinprobably could use some duplicate dependency control, because the underlying driver API won't accept them. But that is a problem for another PR