[STF] Use virtual dispatch for is_graph_ctx() for extensibility#8042
Merged
caugonnet merged 2 commits intoNVIDIA:mainfrom Mar 18, 2026
Merged
[STF] Use virtual dispatch for is_graph_ctx() for extensibility#8042caugonnet merged 2 commits intoNVIDIA:mainfrom
caugonnet merged 2 commits intoNVIDIA:mainfrom
Conversation
- Add virtual bool is_graph_ctx() in backend_ctx (default false) - Override in graph_ctx to return true - Expose is_graph_ctx() on context_handle (pimpl) - context::is_graph_ctx() delegates via variant visitor to backend Replaces brittle payload.index() == 1 check so new context types can participate without changing call sites. Made-with: Cursor
Contributor
Contributor
Author
|
/ok to test dd047ce |
2 tasks
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test 5d561f3 |
Contributor
🥳 CI Workflow Results🟩 Finished in 26m 56s: Pass: 100%/48 | Total: 9h 56m | Max: 19m 58s | Hits: 82%/23725See results here. |
miscco
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces brittle payload.index() == 1 check so new context types can participate without changing call sites.
Description
closes
Checklist