Skip to content

Implement cudax::group concept#8046

Merged
davebayer merged 1 commit intoNVIDIA:mainfrom
davebayer:groups1
Mar 17, 2026
Merged

Implement cudax::group concept#8046
davebayer merged 1 commit intoNVIDIA:mainfrom
davebayer:groups1

Conversation

@davebayer
Copy link
Copy Markdown
Contributor

@davebayer davebayer commented Mar 16, 2026

This PR implements cudax::group concept.

@davebayer davebayer self-assigned this Mar 16, 2026
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Mar 16, 2026
@davebayer davebayer changed the title Implement cudax::group concept Implement cudax::group concept Mar 16, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Progress in CCCL Mar 16, 2026
@NVIDIA NVIDIA deleted a comment from copy-pr-bot Bot Mar 16, 2026
@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented Mar 16, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Comment thread cudax/include/cuda/experimental/__hierarchy/this_group.cuh Outdated
@davebayer davebayer marked this pull request as ready for review March 17, 2026 08:49
@davebayer davebayer requested a review from a team as a code owner March 17, 2026 08:49
@davebayer davebayer requested a review from caugonnet March 17, 2026 08:49
@cccl-authenticator-app cccl-authenticator-app Bot moved this from In Progress to In Review in CCCL Mar 17, 2026
@davebayer davebayer requested review from pciolkosz and removed request for caugonnet March 17, 2026 08:54
Comment thread cudax/include/cuda/experimental/__hierarchy/concepts.cuh Outdated
@github-actions

This comment has been minimized.

Comment on lines +159 to +163

[[nodiscard]] _CCCL_DEVICE_API const _Hierarchy& hierarchy() const noexcept
{
return __base_type::__hier_;
}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had to move the implementation from the base class here, because of some nvcc 12.0 bugs that made the concept fail

@github-actions
Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 14m 11s: Pass: 100%/48 | Total: 3h 17m | Max: 13m 54s | Hits: 99%/23725

See results here.

@davebayer davebayer merged commit 52dd6ba into NVIDIA:main Mar 17, 2026
67 of 68 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL Mar 17, 2026
@davebayer davebayer deleted the groups1 branch April 18, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants