Skip to content

Enable clang-diagnositc clang-tidy checks#8939

Merged
Jacobfaib merged 5 commits into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-05-12/clang-diagnostic-umbrella
May 14, 2026
Merged

Enable clang-diagnositc clang-tidy checks#8939
Jacobfaib merged 5 commits into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-05-12/clang-diagnostic-umbrella

Conversation

@Jacobfaib
Copy link
Copy Markdown
Contributor

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Jacobfaib Jacobfaib self-assigned this May 12, 2026
@github-project-automation github-project-automation Bot moved this to Todo in CCCL May 12, 2026
@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented May 12, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@Jacobfaib
Copy link
Copy Markdown
Contributor Author

/ok to test

@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Progress in CCCL May 12, 2026
@Jacobfaib
Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

@Jacobfaib Jacobfaib force-pushed the jacobf/2026-05-12/clang-diagnostic-umbrella branch from 11c6478 to c047c9d Compare May 14, 2026 14:11
@Jacobfaib
Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

@Jacobfaib
Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

@Jacobfaib Jacobfaib changed the title [NOT FOR REVIEW] Enable clang-diagnositc clang-tidy checks Enable clang-diagnositc clang-tidy checks May 14, 2026
@Jacobfaib Jacobfaib marked this pull request as ready for review May 14, 2026 16:30
@Jacobfaib Jacobfaib requested review from a team as code owners May 14, 2026 16:30
@Jacobfaib Jacobfaib requested review from griwes and shwina May 14, 2026 16:30
@cccl-authenticator-app cccl-authenticator-app Bot moved this from In Progress to In Review in CCCL May 14, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 164921b1-c8a0-4ed8-a56d-b8f80ced1c3c

📥 Commits

Reviewing files that changed from the base of the PR and between 5d79bc2 and d880a21.

📒 Files selected for processing (3)
  • .clang-tidy
  • cmake/run_clang_tidy.sh.in
  • cub/benchmarks/bench/scan/exclusive/sum.warpspeed.cu

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated clang-tidy configuration to enable diagnostic checks
    • Adjusted build script to improve command output timing during analysis
    • Suppressed benchmark warning during code analysis invocation

Walkthrough

PR adds clang-diagnostic-* to clang-tidy enabled checks, defers command tracing in the run script until after argument setup, and suppresses benchmark warnings during clang-tidy invocation.

Changes

Clang-tidy diagnostic checks and invocation

Layer / File(s) Summary
Clang-tidy configuration and script improvements
.clang-tidy, cmake/run_clang_tidy.sh.in
Diagnostic check group is enabled in config; run script moves set -x tracing to after clang_tidy_args computation, keeping set -euo pipefail enabled from the start.
Benchmark warning suppression during clang-tidy
cub/benchmarks/bench/scan/exclusive/sum.warpspeed.cu
SM100+ disabling warning is now suppressed when _CCCL_CLANG_TIDY_INVOKED is defined, reducing diagnostic noise during clang-tidy runs.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Jacobfaib Jacobfaib enabled auto-merge (squash) May 14, 2026 17:20
@github-actions
Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 1h 25m: Pass: 100%/500 | Total: 4d 13h | Max: 55m 31s | Hits: 100%/620924

See results here.

@Jacobfaib Jacobfaib merged commit 5454cfc into NVIDIA:main May 14, 2026
522 checks passed
@Jacobfaib Jacobfaib deleted the jacobf/2026-05-12/clang-diagnostic-umbrella branch May 14, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants