Final env-passthrough 2/4#8979
Open
gonidelis wants to merge 7 commits into
Open
Conversation
* add in docs that memory_resource can also be passed in env * add enable_ifs to beat existing ambiguities with non-env APIs * match 1-1 the non-env APIs to the env APIs identities (defaults, arguments order)
* its purpose is to guard against ambiguities introduced with env algorithms * it also extends as a ground for placing the literalinclude examples as we extract them from the hardcoded snippets in the docs
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (13)
📝 WalkthroughSummary by CodeRabbit
WalkthroughFive core CUB device algorithms simplify their environment-based API template constraints by replacing iterator-type SFINAE guards with integral ChangesEnvironment API constraint and documentation updates
Legacy API overload resolution test coverage
Environment API test refactoring for stream_ref direct usage
Suggested reviewers
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
Contributor
😬 CI Workflow Results🟥 Finished in 1h 41m: Pass: 13%/283 | Total: 5d 05h | Max: 1h 40m | Hits: 7%/240102See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles #8175 for
the most serious issues have to do with defaults in adjacentdifference and ambiguities they were created.
I chose to start introducing non-env api file tests to check that the non-env APIs work in their minimal form. That is when default args are not explicitly passed. These files will facilitate as ground for extracting the example snippets from non env overloads from doxygen to literalincludes later on.