Use the new tuning API internally for detail::batched_topk::dispatch#9095
Draft
bernhardmgruber wants to merge 2 commits into
Draft
Use the new tuning API internally for detail::batched_topk::dispatch#9095bernhardmgruber wants to merge 2 commits into
detail::batched_topk::dispatch#9095bernhardmgruber wants to merge 2 commits into
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
@elstehle Does the changeset proposed by this PR even make sense at this point? It seems there is no public API for batched topk yet, but I am going through benchmarks and move them from the two step allocation to the environment overload that does the allocation automatically. Should I instead just leave a note in the benchmark to update them later? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8482