Fix sccache summary to count CUDA sub-tool cache hits#2046
Open
leofang wants to merge 1 commit intoNVIDIA:mainfrom
Open
Fix sccache summary to count CUDA sub-tool cache hits#2046leofang wants to merge 1 commit intoNVIDIA:mainfrom
leofang wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
The rapidsai/sccache fork tracks CUDA compilation sub-phases under separate language keys in the JSON stats: "CUDA" (nvcc driver), "CUDA (Device code)" (cudafe++), "PTX" (cicc), and "CUBIN" (ptxas). The summary script only counted the "CUDA" key, which represents just the top-level nvcc pass and typically shows 0 cache hits. All the actual cache hits land in the sub-tool categories. This caused the step summary to report 0% hit rate even when sccache's own stats showed ~34%. Include all CUDA-related language keys so the reported rate matches sccache's own "Cache hits rate" output.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sccache step summary under-reports the cache hit rate because CUDA sub-tool compilations are excluded from the count.
The rapidsai/sccache fork tracks CUDA compilation sub-phases under separate language keys in its JSON stats:
"CUDA"— nvcc driver pass"CUDA (Device code)"— cudafe++ pass"PTX"— cicc pass"CUBIN"— ptxas passThe summary script only counted
{"C/C++", "CUDA"}, which captures the nvcc driver pass only. That pass typically has 0 cache hits — the actual hits all land in the sub-tool categories.This PR adds the missing keys so the reported rate matches sccache's own output.
Related:
Test plan