Add short cu12/cu13 Docker tag aliases and update docs#1370
Add short cu12/cu13 Docker tag aliases and update docs#1370rgsl888prabhu wants to merge 2 commits into
Conversation
Publish short `cu<major>` image tags (latest-cu12, latest-cu13, <version>-cu12/cu13) as aliases of the existing fully-qualified `-cuda<minor>-py<py>` tags, matching the pip/conda wheel suffix convention. The fully-qualified tags are kept unchanged. Update the user-facing docs (README, install-selector, NIM operator examples, gRPC examples) and the regression config to lead with the short tags. Skill docs/evals are tracked separately in #1369. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughWalkthroughThis PR standardizes cuOpt Docker image tagging from verbose CUDA/Python-specific formats to simplified tags based on CUDA major version (cu12, cu13). The manifest generation script creates the new tags, documentation explains the scheme, interactive tooling generates commands using the new tags, and deployment examples demonstrate their usage. ChangesDocker image tagging scheme migration from CUDA/Python-suffixed to simplified tags
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
139-141: ⚡ Quick winConsider clarifying Python version selection for short tags.
The documentation explains the new simplified tags but doesn't specify which Python version the short tags (e.g.,
latest-cu12,26.6.0-cu12) correspond to when multiple Python versions are supported. Users may need to know whetherlatest-cu12uses Python 3.13, 3.14, or the latest supported version.Consider adding a sentence like: "Short tags use the latest supported Python version for that release" or similar guidance.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 139 - 141, Clarify which Python version short Docker tags map to by adding a sentence in the README where you describe short tags (references: "latest", "<version>-cu12", "<version>-cu13", and examples like "26.6.0-cu12"); state that short tags implicitly use the latest supported Python minor for that CUDA/release (e.g., "Short tags use the latest supported Python version for that release") and optionally add a note pointing readers to the fully-qualified tags (e.g., "26.6.0-cuda12.9-py3.14") if they need to pin a specific Python version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@README.md`:
- Around line 139-141: Clarify which Python version short Docker tags map to by
adding a sentence in the README where you describe short tags (references:
"latest", "<version>-cu12", "<version>-cu13", and examples like "26.6.0-cu12");
state that short tags implicitly use the latest supported Python minor for that
CUDA/release (e.g., "Short tags use the latest supported Python version for that
release") and optionally add a note pointing readers to the fully-qualified tags
(e.g., "26.6.0-cuda12.9-py3.14") if they need to pin a specific Python version.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0f0aab88-406d-4e9e-ad46-d557fe362748
📒 Files selected for processing (9)
README.mdci/docker/create_multiarch_manifest.shdocs/cuopt/source/_static/install-selector.jsdocs/cuopt/source/cuopt-grpc/advanced.rstdocs/cuopt/source/cuopt-server/nim-operator/configuration.rstdocs/cuopt/source/cuopt-server/nim-operator/guide/cuopt-nimservice-full.yamldocs/cuopt/source/cuopt-server/nim-operator/guide/cuopt-nimservice.yamldocs/cuopt/source/cuopt-server/nim-operator/guide/deploy.shregression/config.sh
Publishes short
cu<major>Docker image tags (latest-cu12,latest-cu13,<version>-cu12/cu13) as aliases of the existing fully-qualified-cuda<minor>-py<py>tags, matching the pip/conda wheel suffix convention. The fully-qualified tags are unchanged — this is purely additive on the publish side.Docs (README, install-selector, NIM operator examples, gRPC examples) and the regression config now lead with the short tags.
Note: short aliases only exist for builds after this change lands (26.6.0+). Skill docs/evals are tracked in #1369.
🤖 Generated with Claude Code