Skip to content

Print logs when exception is caught#1590

Open
akifcorduk wants to merge 4 commits into
NVIDIA:mainfrom
akifcorduk:exception_logging
Open

Print logs when exception is caught#1590
akifcorduk wants to merge 4 commits into
NVIDIA:mainfrom
akifcorduk:exception_logging

Conversation

@akifcorduk

Copy link
Copy Markdown
Contributor

Previously, exceptions inside the MIP OpenMP region were caught silently and rethrown after the region ended. Now their message is logged when caught while preserving the deferred rethrow.

@akifcorduk akifcorduk added this to the 26.08 milestone Jul 20, 2026
@akifcorduk
akifcorduk requested a review from a team as a code owner July 20, 2026 13:10
@akifcorduk akifcorduk added the non-breaking Introduces a non-breaking change label Jul 20, 2026
@akifcorduk
akifcorduk requested review from Bubullzz and mlubin July 20, 2026 13:10
@akifcorduk akifcorduk added the improvement Improves an existing functionality label Jul 20, 2026
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6eef0aca-b0d8-40c7-91e1-99f2193c7f61

📥 Commits

Reviewing files that changed from the base of the PR and between 8148a4f and 1d46be1.

📒 Files selected for processing (2)
  • cpp/src/pdlp/solve.cu
  • cpp/tests/linear_programming/pdlp_test.cu

📝 Walkthrough

Walkthrough

The change adds typed standard-exception logging and deferred propagation to MIP and concurrent PDLP execution, and extends a PDLP test to verify emitted exception messages.

Changes

Exception handling

Layer / File(s) Summary
MIP exception handling
cpp/src/mip_heuristics/solve.cu
solve_mip logs std::exception messages, captures exceptions for deferred rethrow, and retains catch-all handling for unknown exceptions.
Concurrent PDLP exception handling and validation
cpp/src/pdlp/solve.cu, cpp/tests/linear_programming/pdlp_test.cu
Barrier, Dual Simplex, and synchronous PDLP paths log standard exception messages, preserve exception pointers, request concurrent halts, and validate the emitted logs in the exception test.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: bubullzz, chris-maes, hlinsen

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: logging exception details when caught, while keeping deferred rethrow behavior.
Description check ✅ Passed The description accurately describes the exception-logging change in the MIP OpenMP region and remains related to the PR.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@aliceb-nv aliceb-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also check the lp/ side of the codebase for similar patterns

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

CI Test Summary

1 failed · 30 passed · 0 skipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants