enforce 'yamllint' checks#1613
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
| coverage: | ||
| status: | ||
| project: off | ||
| project: off # yamllint disable-line rule:truthy |
There was a problem hiding this comment.
codecov's docs explicitly say to use off here: https://docs.codecov.com/docs/gitlab-4b-setting-coverage-standards-with-flags
Let's not touch it.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesYAML linting rollout
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
CI Test Summary✅ All 31 test job(s) passed. |
Description
Proposes enforcing
yamllintchecks here. My primary motivation is to catch correctness issues independencies.yamlfiles, like duplicate entries silently resolving to the last one or indentation mistakes leading to filters being ignored.But this also has some side benefits for consistency, which makes it a bit easier to write automation.
Issue
Contributes to rapidsai/build-planning#305
Checklist