feat(machine-a-tron): add configurable mock MAC address pool#2673
Closed
poroh wants to merge 1 commit into
Closed
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
poroh
force-pushed
the
machine-a-tron-mac-pools
branch
6 times, most recently
from
bce6199 to
cf0d9c4
Compare
Extract mock MAC allocation into a shared allocator crate and thread an explicit pool through bmc-mock and machine-a-tron. Use the pool for mock machine, hardware, Redfish, and discovery MAC generation, and add machine-a-tron config for customizing the mock MAC address range. Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
poroh
force-pushed
the
machine-a-tron-mac-pools
branch
from
cf0d9c4 to
2503c57
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract mock MAC allocation into a shared allocator crate and thread an explicit pool through bmc-mock and machine-a-tron. Use the pool for mock machine, hardware, Redfish, and discovery MAC generation, and add machine-a-tron config for customizing the mock MAC address range.
Related issues
#2617
Type of Change
Breaking Changes
Testing
Additional Notes