feat(pylon): handle Dynamo request-priority headers in Pylon - #673
Draft
along-2017 wants to merge 1 commit into
Draft
feat(pylon): handle Dynamo request-priority headers in Pylon#673along-2017 wants to merge 1 commit into
along-2017 wants to merge 1 commit into
Conversation
Pylon owns the engine-facing Dynamo header contract. On every tunneled inference request it now strips inbound x-dynamo-request-* headers so client-supplied values never reach the engine, and derives x-dynamo-request-priority from x-priority when that header is present (i32::MAX - min(x, i32::MAX); absent stays absent). Derivation sits behind the default-on --pylon-derive-dynamo-priority flag as a kill switch; the strip is unconditional. The emitted value is logged with the request id and recorded on the upstream request span. mock-dynamo records the priority headers seen on the latest request per endpoint and model in its /test-control snapshot so cluster QA can assert what actually reached the engine. The pylon and mock-dynamo crates gain rust_test Bazel targets; their in-crate tests previously did not run in CI. Refs: #620 Signed-off-by: along <along@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
🛡️ CodeQL Analysis🚨 Found 2 issue(s) Severity Breakdown:
📋 Top Issues🔗 View full details in Security tab 🕐 Last updated: 2026-08-04 22:29:46 UTC | Commit: 1c43f89 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Additional Details (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
For the Reviewer
For QA (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
Issues
Checklist