Skip to content

fix(self-managed): configure LLM router worker address - #679

Open
mikeyrcamp wants to merge 6 commits into
release-deploy/stacks/self-managed/v0.7from
agent/backport-v0.7-llm-router-worker-address
Open

fix(self-managed): configure LLM router worker address#679
mikeyrcamp wants to merge 6 commits into
release-deploy/stacks/self-managed/v0.7from
agent/backport-v0.7-llm-router-worker-address

Conversation

@mikeyrcamp

@mikeyrcamp mikeyrcamp commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

TL;DR

Backport the reviewed self-managed LLM request-router worker-address contract to the v0.7 release branch. Colocated deployments use the cluster-local service by default, while split deployments can provide a worker-reachable override.

Additional Details

Why

The v0.7 stack did not populate the LLM request-router worker address consumed by generated LLM workers. Compute agents can reject LLM launches without that address. The release needs a safe colocated default and a topology-owned override for split deployments.

What changed

  • Added global.workerEndpoints.llmRequestRouterAddress as an optional topology override.
  • Defaulted empty or omitted values to llm-request-router.nvcf.svc.cluster.local:50071.
  • Derived the cluster-local default and request-router chart service from the same configurable gRPC port.
  • Validated explicit DNS or IPv4 host:port and bracketed IPv6 host:port overrides, including port bounds.
  • Mapped the effective address through api.remoteConfig.configData.nvcf.llm-request-router.worker-address.
  • Kept disabled LLM deployments from receiving a staged worker address.
  • Removed redundant local fixture values so local rendering and BDD wiring exercise the default path.
  • Updated installation, enablement, local-development, and topology guidance.

Customer Release Notes

Self-managed v0.7 LLM deployments with colocated workers now use llm-request-router.nvcf.svc.cluster.local:50071 automatically. Split deployments must override global.workerEndpoints.llmRequestRouterAddress with a request-router host and port reachable from worker pods.

Plan Summary

Configuration-only backport. No Kubernetes resources, chart versions, release pins, or replica counts are changed.

Usage

Colocated deployments require no additional worker-address configuration. The cluster-local address follows addons.llm.requestRouter.service.grpcPort when a non-default service port is configured. For a split deployment, configure an override before enabling the LLM add-on:

global:
  workerEndpoints:
    llmRequestRouterAddress: router.example.com:50071

Testing

  • make -C deploy/stacks/self-managed test
  • go test -short ./... from tests/bdd
  • ./tools/ci/check-docs
  • Bash syntax validation
  • git diff --check

Notes

Split-cluster router network exposure is tracked separately in #689.

The v0.7 branch retains its existing stack and chart version pins. No API chart bump is required because v0.7 already pins a chart with the nested remote-config path.

References

Related Pull Requests

Dependencies

None. No third-party dependency, license, or NOTICE changes.

For the Reviewer

Please compare the default and explicit-override behavior with #678 and confirm the release branch retains its existing v0.7 version pins.

For QA

QA is recommended for one colocated and one split-cluster v0.7 LLM function launch. The focused render tests and non-live BDD suite are green.

Issues

Relates to #676

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Mike Camp <mcamp@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0f85688e-b83b-4726-b833-8c17e0b18972

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@mikeyrcamp
mikeyrcamp marked this pull request as ready for review August 5, 2026 14:29
@mikeyrcamp
mikeyrcamp requested review from a team as code owners August 5, 2026 14:29
@mikeyrcamp
mikeyrcamp requested a review from apartha-nv August 5, 2026 14:29
Signed-off-by: Mike Camp <mcamp@nvidia.com>
(cherry picked from commit 109256d)
Signed-off-by: Mike Camp <mcamp@nvidia.com>
(cherry picked from commit e2d90a0)
Signed-off-by: Mike Camp <mcamp@nvidia.com>
(cherry picked from commit 1bfb51fa52b530f0716836abbb5078b8a892832f)
Use the colocated request-router service when the worker endpoint override is empty. Document the field as a split-cluster override.

Relates to #676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants