feat: nscale api change

[ravisoundar]

Description

Updates the nscale provider to use the list-placement-servers end point instead of the instances api.

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.
• All commits are signed off per DCO (git commit -s).

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[greptile-apps]

Greptile Summary

The PR migrates Nscale node discovery from the region-scoped instances API to the placement-scoped servers API.

• Adds the required placementId provider parameter and updates configuration validation.
• Fetches and maps placement-server IDs to hostnames for Slurm discovery.
• Updates the simulation client, API/error tests, and provider documentation.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code defect established.

The provider consistently validates and passes the new placement identifier, parses the documented server metadata fields, and updates its interface implementations, tests, and documentation together.

Important Files Changed

Filename	Overview
pkg/providers/nscale/provider.go	Replaces instances lookup with placement-server discovery, adds placement configuration validation, and preserves node filtering behavior.
pkg/providers/nscale/provider_sim.go	Renames the simulated client method to satisfy the updated Nscale client interface.
pkg/providers/nscale/provider_test.go	Updates loader and mapping coverage for placement IDs and adds placement API error-response tests.
docs/providers/nscale.md	Documents the new endpoint, required placement ID, credentials, examples, and verification commands.

Sequence Diagram

sequenceDiagram
    participant Slurm
    participant Provider as Nscale Provider
    participant Placement as Placement Servers API
    participant Radar as Radar API
    Slurm->>Provider: Resolve node names
    Provider->>Placement: "GET /api/v2/placements/{placementId}/servers"
    Placement-->>Provider: metadata.id and metadata.name
    Provider-->>Slurm: instance-ID-to-node map
    Provider->>Radar: GET /v1/topology
    Radar-->>Provider: instance IDs and network paths
    Provider->>Provider: Join topology with node map

Loading

_{Reviews (1): Last reviewed commit: "feat: nscale api change" | Re-trigger Greptile}