Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of the length scale constraints in the Julia package. There is a high-level api provided by
SSP.constraint_solidandSSP.constraint_voidthat calculates the constraints, with some limitations, and has ChainRulesCore.jl rrules. I also have a low-level api inSSP.Constrainthat provides aLengthConstraintProblemwith more flexibility regarding the points at which the constraints are imposed and manual adjoints.An example of the high-level api is in
SSP/examples/julia/ssp_constrained.jland an example of the low-level api is inSSP/examples/julia/constraint.jlI have tested these on real problems and they are working well.
I still need to write documentation for the new apis. Update: done