Summer clean up - #157
Merged
Merged
Conversation
…type hints and documentation
…coded readInletArea comment parsing by doing a lines[4]
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 28, 2026
* arguments were missing * missing f string * missing another f string * passing optional file name so that we can have a useful log * rogue name edit * missing logger, but we want Value error anyway * use np.bincount and fix the conditioning * add unit test * dedupe openfoam field header scan and fix error handling * avoid scaling multiple times from g/mol to kg/mol * make sure get ind gas and get ind liq work even with uniform fields * remove the star imports * add a weighted averaged function to avoid bugs in the averaging * breakup post quantities * split up ofio * wrong docstrings, I had copy pasted it from cell_volumes * write_this_block was repeated, we moved it to mesh_tools. Also added type hints and documentation * uniformize (for now) the OF v * inlet-area parsing through a robust shared reader. Before, I had hardcoded readInletArea comment parsing by doing a lines[4] * loop instead of repeating code * avoid unintended expression replacement when calling eval( * add a write_face function to make write patches less verbose * add docstrings and dedupe indexed-var writes * handle non matching coarsening and number of blocks * make sure multiring template works * split superficial velocity into pv and numpy branches * unused imports * remove calibration tut * new cleaned up bird version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove spurious bugs I have noticed recently