Promote release 0.90.4 to main #100
Merged
Merged
Conversation
Co-authored-by: Glenn Hamilton-Smith <glenniumhs@gmail.com>
Co-authored-by: syed-awsaf-informed <197770623+syed-awsaf-informed@users.noreply.github.com> Co-authored-by: cruddasj <james.cruddas@informed.com>
✅ OSS Checks PassedAll tracked OSS checks passed in this run.
Results from commit b3d53eb, view the full job summary |
There was a problem hiding this comment.
Pull request overview
Promotes release 0.90.4 to main, primarily aligning repository metadata/documentation and CI/CD workflows with the National-Node-Net organisation and updating the release automation approach.
Changes:
- Update org/repo links across docs, Docker labels, and Maven SCM metadata.
- Refactor GitHub Actions: split GitHub release/tag/SBOM publishing into a dedicated workflow; add OSS checks and auto back-merge workflow; remove some legacy checks.
- Update changelog entry for 0.90.4 and adjust tests (removing S3 upload happy-path assertion).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/uk/gov/dbt/ndtp/extractor/dump/S3BucketDumperTest.java | Removes the S3 upload happy-path test; retains failure/null-path tests. |
| README.md | Updates org links and adds a brief unit test run instruction. |
| pom.xml | Updates SCM URLs and removes Spotless markdown formatting config. |
| INSTALLATION.md | Updates Docker image naming and linked repos to the new org. |
| Dockerfile | Updates OCI image.source label to new org URL. |
| CONTRIBUTING.md | Updates contributor/issue/project links to the new org. |
| CHANGELOG.md | Replaces Unreleased placeholders with a 0.90.4 entry. |
| ACKNOWLEDGEMENTS.md | Updates contributors URL to new org. |
| .github/workflows/release.yml | Removes tag/release creation jobs (publishing handled elsewhere now). |
| .github/workflows/publish-github-release.yml | New workflow to generate SBOM, create tag, and publish GitHub release on merged release/hotfix PRs. |
| .github/workflows/oss-checker.yml | New OSS/policy/template checks workflow with PR commenting and artifacts. |
| .github/workflows/gitflow-release-checks.yml | Removed legacy release branch version checks workflow. |
| .github/workflows/gitflow-pr-target-check.yml | Adds SPDX/copyright header. |
| .github/workflows/gitflow-branch-naming.yml | Adds SPDX/copyright header. |
| .github/workflows/conventional-commits.yml | Removes conventional commit PR title validation workflow. |
| .github/workflows/ci-pr.yml | Adds SPDX/copyright header. |
| .github/workflows/auto-back-merge.yml | New workflow to back-merge main into develop after PR merges. |
| .github/PULL_REQUEST_TEMPLATE.md | Adds PR template content. |
| .github/dependabot.yml | Adds SPDX/copyright header. |
Comments suppressed due to low confidence (1)
src/test/java/uk/gov/dbt/ndtp/extractor/dump/S3BucketDumperTest.java:90
- The success-path
upload()test that asserted the uploaded object contents was removed. This leaves only negative/null tests and no longer verifies thatS3BucketDumper.uploadactually persists the expected bytes to S3 in the happy path.
@Test
void upload_failure_with_client() {
ByteArrayInputStream input = new ByteArrayInputStream("test-data".getBytes(StandardCharsets.UTF_8));
CompletableFuture<Void> task = CompletableFuture.runAsync(
() -> {
DataDumperException e = assertThrows(DataDumperException.class, () -> underTest.upload(input));
assertTrue(e.getMessage().startsWith("Failed to upload file to S3 bucket test-bucket with key "));
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
60
to
+65
| - name: Print Tag Version | ||
| id: print_tag | ||
| env: | ||
| EXTRACTED_VERSION: ${{ steps.extract_version.outputs.version }} | ||
| run: | | ||
| echo "Identified release semantic version: ${{ steps.extract_version.outputs.version }}" | ||
| echo "Identified release semantic version: $EXTRACTED_VERSION" |
Comment on lines
+113
to
+122
| uses: rickstaa/action-create-tag@a1c7777fcb2fee4f19b0f283ba888afa11678b72 # v1.7.2 | ||
| with: | ||
| tag: "v${{ needs.versioning.outputs.version }}" | ||
| message: "Release v${{ needs.versioning.outputs.version }}" | ||
| force_push_tag: true | ||
| # Tag the HEAD commit from the merged release branch not the merge commit to | ||
| # ensure the tag points to the correct source code state for the release. | ||
| # This ensures that the release tag is also visible on any branch which does | ||
| # not contain the merge commit such as develop. | ||
| commit_sha: ${{ github.event.pull_request.head.sha }} |
Comment on lines
18
to
+19
| If you want to see which suppliers and organisations have contributed to this repository in the past, refer to [ACKNOWLEDGEMENTS.md](ACKNOWLEDGMENTS.md) and the GitHub | ||
| contributor insights page at [Contributors](https://github.com/National-Digital-Twin/data-extractor/graphs/contributors). | ||
| contributor insights page at [Contributors](https://github.com/National-Node-Net/data-extractor/graphs/contributors). |
Comment on lines
+1
to
+4
| <!-- | ||
| Before you open a pull request please review the following guidelines and tip and edit the relevant sections. | ||
| Thank you for contributing! | ||
| --> |
cruddasj
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote release 0.90.4 to main