Skip to content

Fix bug with concatenation of processids to query in loop #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aanil merged 2 commits into from
Jul 2, 2025
Merged

Fix bug with concatenation of processids to query in loop #176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d78ba1
Fix bug with concatenation of processids to query in loop
aanil Jul 2, 2025
f7834ee
Ruff
aanil Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions LIMS2DB/classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,18 +947,16 @@ def get_library_preps(self, sample):
# If only Aggregate QC step exists, use it even if it's a pool
if len(agrlibvals) == 1:
agrlibval = agrlibvals[0]
query += f"{agrlibval.processid}"
try:
inp_artifact = self.session.query(Artifact).from_statement(text(query)).first()
inp_artifact = self.session.query(Artifact).from_statement(text(query + f"{agrlibval.processid}")).first()
except NoResultFound:
pass
else:
for agrlv in agrlibvals:
# for small rna (and maybe others), there is more than one agrlibval, and I should not get the latest one,
# but the latest one that ran at sample level, not a pool level.
query += f"{agrlv.processid}"
try:
inp_artifact = self.session.query(Artifact).from_statement(text(query)).first()
inp_artifact = self.session.query(Artifact).from_statement(text(query + f"{agrlv.processid}")).first()

# We want the QC results of individual sample, not library pool
if (
Expand Down