Default the window zoom factor instead of passing NaN - #137
Open
sadiqk2 wants to merge 1 commit into
Open
Conversation
window/open treats zoomFactor as optional, but parseFloat(undefined) is NaN and setZoomFactor(NaN) renders the page at an extreme zoom rather than being ignored. Native\Desktop\Windows\Window declares $zoomFactor = 1.0 and always serialises it, so the Laravel client never reaches this path — it only shows up for a caller that omits the key.
Author
|
@simonhamp kindly review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window/opendestructureszoomFactorfrom an optional payload and later does:When the key is absent that is
parseFloat(undefined)→NaN, andsetZoomFactor(NaN)does not no-op — the page renders at an extreme zoom. I hit this with a window showing about four enormous letters and no other symptom.Native\Desktop\Windows\Windowdeclaresprotected float $zoomFactor = 1.0and always serialises it, so the Laravel client never reaches this path. It only surfaces for a caller that omits the key, which the endpoint otherwise permits.The fix falls back to
1for anything non-finite or non-positive.