Return 404 from window/current when no window is focused - #138
Open
sadiqk2 wants to merge 1 commit into
Open
Conversation
getFocusedWindow() returns null whenever the app has no focused window — it is in the background, or every window is hidden — and the id is read from it without a check, so the handler throws. Reachable from any PHP process that is not driving the UI: a queue worker or the scheduler calling Window::current() will hit it whenever the user is elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getFocusedWindow()returnsnullwhen the app has no focused window — backgrounded, or all windows hidden — so.idthrows.getWindowData(undefined)then throws a bare string rather than anError, which is awkward to surface.This is reachable from any PHP process that is not driving the UI. A queue worker or the scheduler calling
Window::current()hits it whenever the user has the app in the background, so it fails intermittently and for reasons unrelated to the calling code.404 seemed the closest fit to the existing convention —
window/get/:idalready answers 404 for a window that does not exist. Happy to return something else if you would rather distinguish "no focus" from "no such window".