Send a body with the 400 from shell/trash-item - #139
Open
sadiqk2 wants to merge 1 commit into
Open
Conversation
res.json() with no argument throws inside express, so a trashItem() failure that was caught turns into an unhandled error in the handler instead of the intended 400. Passing the message through also tells the caller why it failed.
Author
|
@simonhamp kindly review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
res.json()with no argument throws in express, so the caught failure becomes an unhandled error inside the handler rather than the 400 the code intends. The caller sees a hung or 500 request instead of a clean failure.Passing the message through also means the caller learns why — trashing fails for ordinary reasons (a permission problem, a path on a volume without a trash) and
PHP-sideShell::trash()currently has no way to report which.