Report notifyLaravel failures under SHELL_VERBOSITY - #140
Open
sadiqk2 wants to merge 1 commit into
Open
Conversation
Every failure posting to the PHP app is currently swallowed, so an app that is down, 500ing or 403ing looks exactly like a healthy one — no event arrives and nothing says why. Gated on SHELL_VERBOSITY so normal runs stay quiet, matching how php.ts already gates its command logging.
Author
|
@simonhamp kindly review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every failure here is discarded, which makes these indistinguishable from a healthy app:
PreventRegularBrowserAccessreturns 403 because the secret does not match/_native/api/eventsroute at allIn each case no event arrives, nothing appears in the Electron console, and the only symptom is a UI that quietly does not respond to native events.
This gates a
console.erroronSHELL_VERBOSITY, whichphp.tsalready uses for its own command logging, so default runs stay as quiet as they are today.I appreciate the empty
catchis deliberate — the runtime should not fall over because the app is briefly unreachable, and that behaviour is unchanged here. Happy to move it behindNODE_ENV === 'development'instead, or to drop the gate entirely, whichever fits better.