Correct stale package metadata - #141
Open
sadiqk2 wants to merge 1 commit into
Open
Conversation
homepage still points at nativephp/laravel, which is archived. The Updater alias points at Native\Electron\Facades\Updater; the class lives at Native\Desktop\Drivers\Electron\Facades\Updater since the packages merged, so the facade currently resolves to a missing class.
Author
|
@simonhamp kindly review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two leftovers from the
nativephp/laravel→nativephp/desktopmerge:homepagepoints athttps://github.com/nativephp/laravel, which is archived.The
Updateralias points atNative\Electron\Facades\Updater:but the class is at
Native\Desktop\Drivers\Electron\Facades\Updater—src/Drivers/Electron/Facades/Updater.php. There is noNative\Electronnamespace in the package, soUpdater::currently resolves to a missing class.Every other alias in that block is already
Native\Desktop\..., so this looks like one that was missed rather than intentional.