Skip to content

Fix: sync plugin name from composer.json on update #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonhamp merged 1 commit into from
Jul 20, 2026
+90 −1
Merged

Fix: sync plugin name from composer.json on update #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Services/PluginSyncService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public function sync(Plugin $plugin): bool
];

if ($composerData) {
if (isset($composerData['name']) && ! $plugin->name) {
if (! empty($composerData['name']) && $composerData['name'] !== $plugin->name) {
$existing = Plugin::where('name', $composerData['name'])
->where('id', '!=', $plugin->id)
->exists();
Expand Down
89 changes: 89 additions & 0 deletions tests/Feature/PluginSyncServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,95 @@ public function test_sync_extracts_mobile_min_version_from_composer_data(): void
$this->assertEquals('^3.0.0', $plugin->fresh()->mobile_min_version);
}

public function test_sync_updates_name_from_composer_when_name_changes(): void
{
$composerJson = json_encode([
'name' => 'acme/renamed-plugin',
]);

Http::fake([
'api.github.com/repos/acme/test-plugin/contents/composer.json' => Http::response([
'content' => base64_encode($composerJson),
]),
'api.github.com/repos/acme/test-plugin/contents/nativephp.json' => Http::response([], 404),
'raw.githubusercontent.com/*' => Http::response('', 404),
'api.github.com/repos/acme/test-plugin/releases/latest' => Http::response([], 404),
'api.github.com/repos/acme/test-plugin/tags*' => Http::response([]),
'api.github.com/repos/acme/test-plugin/contents/LICENSE*' => Http::response([], 404),
]);

$plugin = Plugin::factory()->create([
'name' => 'acme/old-name',
'repository_url' => 'https://github.com/acme/test-plugin',
]);

$service = new PluginSyncService;
$result = $service->sync($plugin);

$this->assertTrue($result);
$this->assertEquals('acme/renamed-plugin', $plugin->fresh()->name);
}

public function test_sync_sets_name_on_initial_sync_when_plugin_has_no_name(): void
{
$composerJson = json_encode([
'name' => 'acme/test-plugin',
]);

Http::fake([
'api.github.com/repos/acme/test-plugin/contents/composer.json' => Http::response([
'content' => base64_encode($composerJson),
]),
'api.github.com/repos/acme/test-plugin/contents/nativephp.json' => Http::response([], 404),
'raw.githubusercontent.com/*' => Http::response('', 404),
'api.github.com/repos/acme/test-plugin/releases/latest' => Http::response([], 404),
'api.github.com/repos/acme/test-plugin/tags*' => Http::response([]),
'api.github.com/repos/acme/test-plugin/contents/LICENSE*' => Http::response([], 404),
]);

$plugin = Plugin::factory()->create([
'name' => null,
'repository_url' => 'https://github.com/acme/test-plugin',
]);

$service = new PluginSyncService;
$result = $service->sync($plugin);

$this->assertTrue($result);
$this->assertEquals('acme/test-plugin', $plugin->fresh()->name);
}

public function test_sync_does_not_overwrite_name_when_taken_by_another_plugin(): void
{
$composerJson = json_encode([
'name' => 'acme/taken-name',
]);

Http::fake([
'api.github.com/repos/acme/test-plugin/contents/composer.json' => Http::response([
'content' => base64_encode($composerJson),
]),
'api.github.com/repos/acme/test-plugin/contents/nativephp.json' => Http::response([], 404),
'raw.githubusercontent.com/*' => Http::response('', 404),
'api.github.com/repos/acme/test-plugin/releases/latest' => Http::response([], 404),
'api.github.com/repos/acme/test-plugin/tags*' => Http::response([]),
'api.github.com/repos/acme/test-plugin/contents/LICENSE*' => Http::response([], 404),
]);

Plugin::factory()->create(['name' => 'acme/taken-name']);

$plugin = Plugin::factory()->create([
'name' => 'acme/original-name',
'repository_url' => 'https://github.com/acme/test-plugin',
]);

$service = new PluginSyncService;
$result = $service->sync($plugin);

$this->assertTrue($result);
$this->assertEquals('acme/original-name', $plugin->fresh()->name);
}

public function test_sync_sets_mobile_min_version_to_null_when_not_in_composer_data(): void
{
$composerJson = json_encode([
Expand Down
Loading