Clickdrag subsystem and autofire enhancements.#5373
Merged
Conversation
MistakeNot4892
added
the
work in progress
MistakeNot4892
force-pushed
the
feature/mousedown
branch
2 times, most recently
from
f757dc6 to
e6c02ad
Compare
5 tasks
MistakeNot4892
changed the title
MistakeNot4892
added
ready for review
MistakeNot4892
force-pushed
the
feature/mousedown
branch
4 times, most recently
from
a31c8d8 to
5fca762
Compare
2 tasks
MistakeNot4892
added
work in progress
Contributor
Author
|
Going to split some of these changes out. |
MistakeNot4892
force-pushed
the
feature/mousedown
branch
2 times, most recently
from
11d115a to
410054e
Compare
MistakeNot4892
changed the title
MistakeNot4892
added
the
has dependencies
MistakeNot4892
force-pushed
the
feature/mousedown
branch
2 times, most recently
from
d06493e to
40514bf
Compare
Contributor
Author
|
Depends on #5375. |
MistakeNot4892
force-pushed
the
feature/mousedown
branch
from
40514bf to
4d9adff
Compare
MistakeNot4892
added
ready for review
out-of-phaze
requested changes
May 20, 2026
| @@ -0,0 +1,53 @@ | |||
| SUBSYSTEM_DEF(clickdrag) | |||
| name = "Clickdrag" | |||
| wait = 1 | |||
Member
There was a problem hiding this comment.
should this be a ticker subsystem instead of just a wait 1 subsystem? given that this handles user input i feel that would be desirable
Contributor
Author
There was a problem hiding this comment.
I don't know how to do this. The ticker we have in code is a 1 second wait.
Contributor
Author
There was a problem hiding this comment.
Nvm I found SS_TICKER
MistakeNot4892
force-pushed
the
feature/mousedown
branch
from
4d9adff to
d447ef9
Compare
out-of-phaze
requested changes
May 20, 2026
Member
out-of-phaze
left a comment
out-of-phaze
left a comment
There was a problem hiding this comment.
should be good to go after SS_NO_INIT is added?
| SUBSYSTEM_DEF(clickdrag) | ||
| name = "Clickdrag" | ||
| wait = 1 | ||
| flags = SS_TICKER |
Member
There was a problem hiding this comment.
probably also needs SS_NO_INIT since there's no initialize override for it?
…at unreliable for fine-grained stuff. Adding cursor updates to mousedrag procs in preparation for melee attack PR.
MistakeNot4892
force-pushed
the
feature/mousedown
branch
from
d447ef9 to
e8b3c90
Compare
out-of-phaze
approved these changes
May 21, 2026
NebulaSS13Bot
added a commit
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
/obj/item.Why and what will this PR improve
Makes click and drag more consistent and simplifies the relevant code.
Authorship
Myself.
Changelog
🆑
tweak: Mech plasmacutter is full auto and mech AR full auto should now work.
tweak: Autofire should be more responsive in general.
/:cl: