Skip to content

Temporary commit to make girders craftable with metal sheets.#5379

Open
MistakeNot4892 wants to merge 1 commit into
NebulaSS13:stablefrom
MistakeNot4892:tweak/girders
Open

Temporary commit to make girders craftable with metal sheets.#5379
MistakeNot4892 wants to merge 1 commit into
NebulaSS13:stablefrom
MistakeNot4892:tweak/girders

Conversation

@MistakeNot4892
Copy link
Copy Markdown
Contributor

No description provided.

@MistakeNot4892 MistakeNot4892 added the ready for review This PR is ready for review and merge. label May 17, 2026
/decl/stack_recipe/steel/girder
result_type = /obj/structure/girder
required_wall_support_value = 10
req_amount = 5 * SHEET_MATERIAL_AMOUNT // Arbitrary value since girders return weird matter values.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dismantling them produces 2 sheets, did you always lose 3 sheets from dismantling?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copypasted from the rods recipe.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Girders have 5 sheets of matter in them so lowering the recipe amount causes CI fails. Them giving 2 sheets on dismantle is due to using parts_amount I guess.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With tweaked code, they drop 3 sheets and cost 6 to craft. I'm happy with that for the moment.

@MistakeNot4892 MistakeNot4892 dismissed out-of-phaze’s stale review May 20, 2026 12:29

Addressed - currently using unmodified structure sheet amounts/logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review This PR is ready for review and merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants