Skip to content

Default autoUpdate to true#396

Open
mxstbr wants to merge 1 commit into
NekR:masterfrom
mxstbr:patch-2
Open

Default autoUpdate to true#396
mxstbr wants to merge 1 commit into
NekR:masterfrom
mxstbr:patch-2

Conversation

@mxstbr

@mxstbr mxstbr commented Jun 27, 2018

Copy link
Copy Markdown
Contributor

Not sure when you'd ever want your ServiceWorker to not update ever? That seems like the way less common case than updating on change.

Not sure when you'd ever want your ServiceWorker to not update ever? That seems like the way less common case than updating on change.
@GGAlanSmithee

GGAlanSmithee commented Jul 25, 2018

Copy link
Copy Markdown
Collaborator

@mxstbr

Thanks for this, makes sense too me. Corresponding docs needs to be updated too.

BTW - is true (= 1 hour) the most reasonable default, or should we have a slightly longer default, say 10 hours or something like that?

@NekR does this update make sense to you?

@mxstbr

mxstbr commented Jul 27, 2018

Copy link
Copy Markdown
Contributor Author

BTW - is true (= 1 hour) the most reasonable default, or should we have a slightly longer default, say 10 hours or something like that?

I think it should be shorter, if anything?

@GGAlanSmithee

Copy link
Copy Markdown
Collaborator

@mxstbr yeah, was thinking it might be a large change going from never auto-updating to once an hour as a default, but I agree it makes more sense to have it be shorter.

@NekR

NekR commented May 9, 2019 via email

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants