Skip to content

fix: stop the kafka watch thread when the client is closed - #170

Open
TaurMorchant wants to merge 3 commits into
mainfrom
fix/maas-client-watch-thread-leak
Open

fix: stop the kafka watch thread when the client is closed#170
TaurMorchant wants to merge 3 commits into
mainfrom
fix/maas-client-watch-thread-leak

docs: state what KafkaMaaSClientCloseTest pins and why it avoids Mock…

5303ccc
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Aug 7, 2026 in 1m 3s

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 157 in maas-client/client/src/main/java/com/netcracker/cloud/maas/client/impl/kafka/KafkaMaaSClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either re-interrupt this method or rethrow the "InterruptedException" that can be caught here. 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ_cSFY8MiVuGAY_eVhj&open=AZ_cSFY8MiVuGAY_eVhj&pullRequest=170

Check warning on line 120 in maas-client/client/src/test/java/com/netcracker/cloud/maas/client/impl/kafka/KafkaMaaSClientCloseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Thread.sleep()". 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ_cSFUuMiVuGAY_eVhh&open=AZ_cSFUuMiVuGAY_eVhh&pullRequest=170

Check failure on line 154 in maas-client/client/src/main/java/com/netcracker/cloud/maas/client/impl/kafka/KafkaMaaSClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the synchronisation mechanism to not use a Thread instance as a monitor 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ_cSFY8MiVuGAY_eVhk&open=AZ_cSFY8MiVuGAY_eVhk&pullRequest=170

Check failure on line 112 in maas-client/client/src/main/java/com/netcracker/cloud/maas/client/impl/kafka/KafkaMaaSClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ_cSFY8MiVuGAY_eVhi&open=AZ_cSFY8MiVuGAY_eVhi&pullRequest=170

Check warning on line 170 in maas-client/client/src/main/java/com/netcracker/cloud/maas/client/impl/kafka/KafkaMaaSClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"notify" may not wake up the appropriate thread. 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ_cSFY8MiVuGAY_eVhl&open=AZ_cSFY8MiVuGAY_eVhl&pullRequest=170

Check failure on line 170 in maas-client/client/src/main/java/com/netcracker/cloud/maas/client/impl/kafka/KafkaMaaSClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the synchronisation mechanism to not use a Thread instance as a monitor 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ_cSFY8MiVuGAY_eVhm&open=AZ_cSFY8MiVuGAY_eVhm&pullRequest=170

Check failure on line 97 in maas-client/client/src/main/java/com/netcracker/cloud/maas/client/impl/kafka/KafkaMaaSClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Fix this access that will throw a NullPointerException when executed. 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ_cSFY9MiVuGAY_eVhn&open=AZ_cSFY9MiVuGAY_eVhn&pullRequest=170
View more details on SonarQubeCloud