Striation speedup#214
Open
SimoneAriens wants to merge 4 commits into
Open
Conversation
cfs-data
reviewed
May 13, 2026
cfs-data
reviewed
May 13, 2026
cfs-data
reviewed
May 13, 2026
cfs-data
reviewed
May 13, 2026
cfs-data
reviewed
May 13, 2026
cfs-data
reviewed
May 13, 2026
cfs-data
approved these changes
May 13, 2026
Collaborator
cfs-data
left a comment
cfs-data
left a comment
There was a problem hiding this comment.
Approved with suggestions
Diff CoverageDiff: origin/main..HEAD, staged and unstaged changes
Summary
|
Minimum allowed line rate is |
vergep
approved these changes
May 19, 2026
Collaborator
vergep
left a comment
vergep
left a comment
There was a problem hiding this comment.
Wellicht nog wat uitleg bij de kruis correlatie formule met 6 termen. Zullen we daar even samen voor gaan zitten?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
especially important when running the bulk conversion
Replaced the brute-force shift loop in _find_best_alignment with FFT-based normalized cross-correlation (scipy.signal.fftconvolve). Mathematically equivalent — computes Pearson correlation at all shifts simultaneously instead of looping over ~8,500 individual calls per comparison.
42× faster: 11.75s → 0.28s per comparison on production data. Validated against the old implementation on synthetic and production pairs (correlation, shift, and scale all match within 1e-6).