Changing the logic for 'input.check' files creation#124
Open
cosimolupo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a preparatory step for CWL integration into Cobrawap as an alternative workflow manager, this PR proposes a different logic for the creation of
input.checkfiles.The old method consisted in
check_input.pyblocks just reading neo files and checking for their consistency, producing no output files. Snakemake rulecheck_inputwas then explicitly asked for the creation of such files, via the shell commandtouch.In the new approach, it is the
check_input.pyblock itself that creates an empty output file namedinput.check, at the end of consistency checks and hence only after their successful ending.--outputcommand-line argument is then added to such blocks. Snakemake rulecheck_inputis changed accordingly, removing the shell command and adding theoutputfield typically used for standard I/O blocks.This new approach greatly helps in the I/O binding between steps in CWL workflows.