[ENH] GPFA with continuous data#539
Draft
Moritz-Alexander-Kern wants to merge 10 commits into
Draft
Conversation
* Allow seqs to be passed directly to gpfa fit * Small fix to error checking * Typo * another typo * fixed formatting for pep8 * fixed docstring of transform after introducing error while resolving merge conflicts * added two unit-test * add more unit-tests * remove blank line --------- Co-authored-by: Jonah Pearl <jonahpearl@g.harvard.edu>
Moritz-Alexander-Kern
added
the
enhancement
Collaborator
Moritz-Alexander-Kern
changed the title
Moritz-Alexander-Kern
changed the title
Moritz-Alexander-Kern
force-pushed
the
enh/GPFA_continous_data
branch
from
dfaa6c7 to
5b966ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extends the functionality of the GPFA classes methods to accept continuous data.
The changes are done to the methods
fit,transformandfit_transform, which now accept continuous data.Unit tests and docstrings have been written to ensure that the changes are properly implemented.
This PR seeks a continuation of the previously started development in PR #507.
The current input for continuous data to
fit,transformandfit_transformis a numpy recarrayTodo
Co-authored-by: Jonah Pearl jonahpearl@g.harvard.edu