Development -> Master#475
Closed
sanjayankur31 wants to merge 346 commits into
Closed
Conversation
We don't need to find this again, we already know the tree root.
While checking the XML string is fine, checking the NeuroML object tree is more future proof. We'll modify the tests to do that as we go.
Otherwise, one has to then re-load the written NeuroML file again.
We'll use these to test our implementation
`create_unbranche_segment` adds one to the root segments of all unbranched segment groups
The first two points belong to the first segment in this case also, and that needed to be correctly recorded. Otherwise, other segments that have the second point as the parent were not referring to the first segment as the parent segment---they were referring to the next segment where the second point was the proximal, not the distal.
Also regenerates all man pages [skip ci]
Use better variable names to clarify what point is being used. Also correctly map points to their corresponding segments.
Otherwise some of our test files don't get committed.
It's EOL
Fix tests
feat: enable py3.14 ci + support
Otherwise we end up with lots of issues related to paths.
WIP, more testing needed
Do not skip if they are default parameters.
[skip-ci]
feat: add script to generate python scripts from xml
Member
|
Sure, but in the past we could do py package releases (tagged here) from development, and just merge gh repos to master on a new release of the nml specs... |
Member
Author
|
Cool, I'll just do that. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cut new release? long overdue.