Fix nginx reload after certificate renewal#5720
Open
DoyoDia wants to merge 1 commit into
Open
Conversation
|
Docker Image for build 1 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A successful Let's Encrypt renewal updates the certificate files on disk, but nginx continues serving the certificate already loaded in memory until it is reloaded.
The shared certificate renewal path did not reload nginx after Certbot completed. This affects both HTTP and DNS challenge renewals, including Cloudflare.
This change calls the existing nginx reload function immediately after a successful renewal, allowing the renewed certificate to be served without restarting the container or manually reloading nginx.
This restores behavior that was lost when auto-renewal was changed to use the shared renewal function in #3392.
Fixes #3803
Type of Change
AI Usage