Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wacky-lizards-attack.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nodesecure/scanner": patch
---

Prioritize repository over homepage in package.json to generate repository link
8 changes: 4 additions & 4 deletions workspaces/scanner/src/utils/getLinks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ export function getLinks(
npm: `https://www.npmjs.com/package/${packumentVersion.name}/v/${packumentVersion.version}`,
homepage,
repository:
getVCSRepositoryURL(homepage) ??
getVCSRepositoryURL(repositoryUrl)
getVCSRepositoryURL(repositoryUrl) ??
getVCSRepositoryURL(homepage)
};
}

Expand All @@ -61,7 +61,7 @@ export function getManifestLinks(
npm: null,
homepage,
repository:
getVCSRepositoryURL(homepage) ??
getVCSRepositoryURL(repositoryUrl)
getVCSRepositoryURL(repositoryUrl) ??
getVCSRepositoryURL(homepage)
};
}
36 changes: 35 additions & 1 deletion workspaces/scanner/test/utils/getLinks.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,29 @@ describe("utils.getLinks", () => {
type: "git",
url: "github.com/foo/bar"
}
} as any), {
} as PackumentVersion), {
npm: "https://www.npmjs.com/package/foo/v/1.0.0",
homepage: "https://github.com/foo/bar",
repository: "https://github.com/foo/bar"
});
});

it("repository url should prioritize repository over homepage", () => {
assert.deepStrictEqual(utils.getLinks({
name: "@nodesecure/utils",
version: "2.3.0",
homepage: "https://github.com/NodeSecure/tree/master/workspaces/utils#readme",
repository: {
type: "git",
url: "https://github.com/NodeSecure/scanner",
directory: "workspaces/utils"
}
} as PackumentVersion), {
npm: "https://www.npmjs.com/package/@nodesecure/utils/v/2.3.0",
homepage: "https://github.com/NodeSecure/tree/master/workspaces/utils#readme",
repository: "https://github.com/NodeSecure/scanner"
});
});
});

describe("utils.getManifestLinks", () => {
Expand Down Expand Up @@ -94,4 +111,21 @@ describe("utils.getManifestLinks", () => {
repository: "https://github.com/foo/bar"
});
});

it("repository url should prioritize repository over homepage", () => {
assert.deepStrictEqual(utils.getManifestLinks({
name: "@nodesecure/utils",
version: "2.3.0",
homepage: "https://github.com/NodeSecure/tree/master/workspaces/utils#readme",
repository: {
type: "git",
url: "https://github.com/NodeSecure/scanner",
directory: "workspaces/utils"
}
}), {
npm: null,
homepage: "https://github.com/NodeSecure/tree/master/workspaces/utils#readme",
repository: "https://github.com/NodeSecure/scanner"
});
});
});
Loading