Skip to content

added potion recipe data#2509

Draft
BinkyBo wants to merge 1 commit into
NotEnoughUpdates:masterfrom
BinkyBo:potion-recipes
Draft

added potion recipe data#2509
BinkyBo wants to merge 1 commit into
NotEnoughUpdates:masterfrom
BinkyBo:potion-recipes

Conversation

@BinkyBo
Copy link
Copy Markdown

@BinkyBo BinkyBo commented Apr 22, 2026

No description provided.

@BinkyBo
Copy link
Copy Markdown
Author

BinkyBo commented Apr 22, 2026

for @HacktheTime's project

@HacktheTime
Copy link
Copy Markdown

for other other users to understand. I got offered some assistance and if merging needs to be done anyway it can be in neu repo directly anyway.

@Bentcheesee
Copy link
Copy Markdown
Contributor

These will likely get cleared out if they get updated by another mod generating jsons (like Firm)

@NopoTheGamer
Copy link
Copy Markdown
Member

this is a bad way to do it, isn't formatted correctly, probably gets deleted by other mods as stated

Copy link
Copy Markdown
Collaborator

@jani270 jani270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
Im gonna stop you here before you spend too much time on this, first of all i support the addition of brewing recipes to neu repo, but this kinda needs a better design. These keys dont mean anything and are kinda random.

As all other recipes this should be in the recipes field like this for shops:

{
      "type": "npc_shop",
      "cost": [
        "SKYBLOCK_COIN:10000000",
        "CROOKED_ARTIFACT"
      ],
      "result": "SEAL_OF_THE_FAMILY"
}

E.g we want something like this: NOT FINAL DESIGN PLEASE DONT USE IT RANDOMLY

  "recipes": [
    {
      "type": "brewing",
      "base: [ 
       "POTION_DAMAGE;1:1,
       "DR_PEPPER:1,
      ]
      "input": [
        "FERMENTED_SPIDER_EYE:1"
      ],
      "result": "POTION_DAMAGE;2"
   }
  ]

@lineargraph
Copy link
Copy Markdown
Member

another mod generating jsons (like Firm)

don't think firm deletes any json key at the top level, but yeah this should be a recipe type

@BinkyBo
Copy link
Copy Markdown
Author

BinkyBo commented Apr 30, 2026

@jani270
would this format for upgrade data be inline with the repo?

"POTION_AGILITY": {
    "baseDuration": 180,
    "redstone": true,
    "upgradedDurations": {"REDSTONE":480,"ENCHANTED_REDSTONE":960,"ENCHANTED_REDSTONE_BLOCK":2400},
    "glowstone": true,
    "gunpowder": true
  },
  "POTION_ALCHEMY_XP_BOOST": {
    "durationType":"complex",
    "redstone": false,
    "glowstone": true,
    "gunpowder": true
  },

this is what is on the wiki about xp boot potions:
image

@jani270
Copy link
Copy Markdown
Collaborator

jani270 commented Apr 30, 2026

@jani270 would this format for upgrade data be inline with the repo?

"POTION_AGILITY": {
    "baseDuration": 180,
    "redstone": true,
    "upgradedDurations": {"REDSTONE":480,"ENCHANTED_REDSTONE":960,"ENCHANTED_REDSTONE_BLOCK":2400},
    "glowstone": true,
    "gunpowder": true
  },
  "POTION_ALCHEMY_XP_BOOST": {
    "durationType":"complex",
    "redstone": false,
    "glowstone": true,
    "gunpowder": true
  },

this is what is on the wiki about xp boot potions: image

Do you want this to be in a constant or what?

@BinkyBo
Copy link
Copy Markdown
Author

BinkyBo commented Apr 30, 2026

Do you want this to be in a constant or what?

yes it would be in a constant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants