expand callNames

[FlyModeZ]

No description provided.

[NopoTheGamer]

why have you done this?

[FlyModeZ]

for skyhanni /call tab complete feature
the hypixel builtin one has some inaccurate names, e.g. "arrow", feast", "drill", also missing some aliases, also is latency-based

[NopoTheGamer]

the skyhanni feature doesnt require you to add pointless callNames

[FlyModeZ]

there's also some fixes for example, the default name for "Frozen Alex" is "FrozenAlex" and it doesn't exist in game.

do you mean I add too much names?
do you want me to only keep only one 1~2 pointful name(e.g. "maxwell" and "thaumaturgist") for each NPC (removing things like "telekinesis_applier", "trevor_the_trapper", "wool", "weaver"...)?

[jani270]

Please remove all callnames that are just the npc name in lower case or the npc name with _ instead of a space

[Alex33856]

there's also some fixes for example, the default name for "Frozen Alex" is "FrozenAlex" and it doesn't exist in game.

The default after the 0.24.3 update should just be the name lowercased, without removing spaces. Those don't need to be added to call names.

[FlyModeZ]

some NPCs only take space/underscore call names("spider_tamer"), some only take no space("fearmongerer"), and some take both.

skyhanni replaces spaces with nothing, so it won't work in the current version of skyhanni if we remove "spider_tamer". It will suggest "SpiderTamer", and the game says Unknown Abiphone Contact!

also the suggestion list was in mixed case.

Do you want me to remove the call names with nospace
or something else?

[FlyModeZ]

there's also some fixes for example, the default name for "Frozen Alex" is "FrozenAlex" and it doesn't exist in game.

The default after the 0.24.3 update should just be the name lowercased, without removing spaces. Those don't need to be added to call names.

/call fear mongerer isn't a thing while /call fearmongerer is

*also in the current version of skyhanni it just removes space

[Alex33856]

1 issue + my thoughts

[Alex33856]

/call fear mongerer isn't a thing while /call fearmongerer is

this is why a call name was added, so the generated "/call fear mongerer" is not used.

*also in the current version of skyhanni it just removes space

well that should be fixed on the SkyHanni side.

[jani270]

Remove

[jani270]

Remove

[jani270]

Remove

[jani270]

Remove

[jani270]

Remove

[jani270]

Remove

[FlyModeZ]

wait hold on,
if we say "Maxwell": {"callNames": ["thaumaturgist"]}, it means both "maxwell" and "thaumaturgist" are vaild.
however in this case -> "Fear Mongerer": {callNames: ["fearmongerer"]}, we don't want the generated "fear mongerer"

do you want to revert last commit?