v3.3: be clear which property we are referring to#5330
Open
karenetheridge wants to merge 1 commit into
Open
Conversation
handrews
approved these changes
May 13, 2026
Member
handrews
left a comment
handrews
left a comment
There was a problem hiding this comment.
Great catch, I assume you will backport to 3.2.1?
karenetheridge
force-pushed
the
ether/v3.3-encoding-data-property
branch
from
d1bcdb8 to
44dc5ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not entirely clear whether this refers to a property in the data instance or a
propertykeyword in the schema. (v3.1 says that encoding properties must correspond to schema properties; in v3.2, the "Encoding by Position" section says that prefixEncoding entries must correspond to a schema indicating an array.)Either way, let's clarify this and be consistent with the rules between object data and array data.