Migrate to yarn to avoid npm workarounds - #5503
Merged
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
miqui
approved these changes
Aug 18, 2026
Contributor
|
@handrews yeah, yarn is a good choice. |
baywet
reviewed
Aug 20, 2026
|
|
||
| - uses: actions/setup-node@v7 | ||
| with: | ||
| node-version: "24.x" |
Member
There was a problem hiding this comment.
Suggested change
| node-version: "24.x" | |
| node-version: "24.x" | |
| cache: "yarn" |
baywet
reviewed
Aug 20, 2026
| @@ -35,8 +35,11 @@ jobs: | |||
| with: | |||
| node-version: "24.x" | |||
Member
There was a problem hiding this comment.
Suggested change
| node-version: "24.x" | |
| node-version: "24.x" | |
| cache: "yarn" |
baywet
reviewed
Aug 20, 2026
| @@ -38,8 +38,11 @@ jobs: | |||
| with: | |||
| node-version: "24.x" | |||
Member
There was a problem hiding this comment.
Suggested change
| node-version: "24.x" | |
| node-version: "24.x" | |
| cache: "yarn" |
baywet
reviewed
Aug 20, 2026
| @@ -27,10 +27,13 @@ jobs: | |||
| with: | |||
| node-version: '24.x' | |||
Member
There was a problem hiding this comment.
Suggested change
| node-version: '24.x' | |
| node-version: '24.x' | |
| cache: 'yarn' |
baywet
reviewed
Aug 20, 2026
| @@ -21,8 +21,11 @@ jobs: | |||
| with: | |||
| node-version: "24.x" | |||
Member
There was a problem hiding this comment.
Suggested change
| node-version: "24.x" | |
| node-version: "24.x" | |
| cache: "yarn" |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See OAI/build-infra#24 for the explanation. NPM has too many weirdnesses with platform-specific issues and interactions with GitHub. Yarn is well-established, well-supported by GitHub, and does not have these problems.
With the latest commit (pushed after opening), this also adds CI tests for the build as we discussed in last week's TDC call: published locations only on
main, dev builds on other branches.Note: We should merge the build-infra PR first!