[18.0][FIX] web: use count limit on the domain field widget#1277
Conversation
|
This PR has the |
Ricardoalso
force-pushed
the
18.0-backport-web-widget-domain-count-limit
branch
from
909aff9 to
a0c6773
Compare
Ricardoalso
left a comment
Ricardoalso
left a comment
There was a problem hiding this comment.
Thanks for this @ivantodorovich
I allowed myself to rebase as there was a conflict in addons/web/static/src/views/fields/domain/domain_field.js
|
Hi @ivantodorovich , any chance to rebase ? |
Executing a search count on a table with a large number of records can be slow, which is why a limit was added on b37d221. The same issue exists on the domain field widget, and so the same solution is applied here. Task 4471410
ivantodorovich
force-pushed
the
18.0-backport-web-widget-domain-count-limit
branch
from
a0c6773 to
24d41c2
Compare
|
done |
|
ping @OCA/web-maintainers , everything is properly tagged. |
|
/ocabot merge minor |
|
Sorry @tarteo you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
@flotho Sorry web maintainers can't merge this! @OCA/backport-maintainers is the correct team |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
This branch has no tests, and this is something of web client, where the test scope may be limited.
The linked runboat doesn't contain the patch as well, so it can be confusing. I have tried in a local DB, and it's working.
8 participants
Backports:
Executing a search count on a table with a large number of records can be slow, which is why a limit was added on b37d221.
The same issue exists on the domain field widget, and so the same solution is applied here.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr