[19.0][OU-ADD] pos_viva_com: rename viva_wallet_* fields to viva_com_*#5644
[19.0][OU-ADD] pos_viva_com: rename viva_wallet_* fields to viva_com_*#5644dnplkndll wants to merge 1 commit into
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
dnplkndll
force-pushed
the
19.0-mig-pos-viva-com-rename
branch
from
1815ce3 to
f7011a6
Compare
dnplkndll
force-pushed
the
19.0-mig-pos-viva-com-rename
branch
from
f7011a6 to
76f28f1
Compare
dnplkndll
changed the title
remi-filament
left a comment
remi-filament
left a comment
There was a problem hiding this comment.
Thanks for this PR @dnplkndll
Migration scripts LGTM
Some administrative/documentation comments
| | |new| pos_viva_com | | | | ||
| | |new| pos_viva_com |Done | | | ||
| +---------------------------------------------------+----------------------+-------------------------------------------------+ | ||
| | |del| pos_viva_wallet | | | |
There was a problem hiding this comment.
You may want to also mark this one as done + note on both that this module was renamed.
There was a problem hiding this comment.
Done in d28c7e6 — pos_viva_com row col 3 = Renamed from pos_viva_wallet; pos_viva_wallet row now Done + col 3 = Renamed to pos_viva_com.
| @@ -0,0 +1,35 @@ | |||
| ---Models in module 'pos_viva_com'--- | |||
| ---Fields in module 'pos_viva_com'--- | |||
| pos_viva_com / pos.payment / viva_com_session_id (char) : NEW | |||
There was a problem hiding this comment.
This one should be marked as NOTHING TO DO
There was a problem hiding this comment.
Added # NOTHING TO DO after the empty Models section in d28c7e6.
| pos_viva_wallet / pos.payment.method / viva_wallet_test_mode (boolean): DEL | ||
| pos_viva_wallet / pos.payment.method / viva_wallet_webhook_verification_key (char): DEL | ||
|
|
||
| # DONE: 9 viva_wallet_* fields renamed to viva_com_* via rename_fields |
There was a problem hiding this comment.
We do not need somuch information in there, you may just state :
| # DONE: 9 viva_wallet_* fields renamed to viva_com_* via rename_fields | |
| # DONE: pre-migration: rename fields``` | |
| And remove the following comment lines |
There was a problem hiding this comment.
Collapsed to single line # DONE: pre-migration: rename fields in d28c7e6.
dnplkndll
force-pushed
the
19.0-mig-pos-viva-com-rename
branch
from
76f28f1 to
d28c7e6
Compare
|
@remi-filament — addressed all three threads in d28c7e6:
Fork CI green on both seeds. Ready for re-review. |
dnplkndll
changed the title
3 participants
pos_viva_walletwas renamed topos_viva_comin 19.0 (handled byapriori.renamed_modules); the credential + config fields onpos.payment.methodALSO got renamedviva_wallet_*→viva_com_*. Without explicitrename_fieldsusers' API keys / tokens / merchant + terminal IDs would be silently lost (rendered as DEL old + NEW empty).openupgradelib.rename_fieldsfor the renamed fields onpos.payment.method.rename_fieldsis a full move (column + ir.model.fields + ir.model.data).docsource notes the module rename on both rows (
pos_viva_com← from /pos_viva_wallet→ to).