[19.0][OU-FIX] project_todo: pre-migrate path collision on ir.actions.act_window#5667
Draft
dnplkndll wants to merge 1 commit into
Draft
[19.0][OU-FIX] project_todo: pre-migrate path collision on ir.actions.act_window#5667dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
…indow 19.0 adds the `path` column on `ir.actions.act_window` with a unique constraint and the schema upgrade pre-populates `path='to-do'` on `project_todo.project_task_action_todo`. When the module's data XML then `_load_records()` re-writes the same row with `path='to-do'`, the @api.constrains check finds the record's own existing value as a duplicate of itself and raises `Path to show in the URL must be unique`, aborting the migration at `project_todo/views/project_task_views.xml:277`. Null the column in pre-migration so the install path can re-set it cleanly.
dnplkndll
force-pushed
the
19.0-mig-project-todo-pre-migration
branch
from
450fb29 to
50c86fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
19.0 adds
ir.actions.act_window.path(unique) and the schema upgradepre-populates it on the existing
project_task_action_todorow; themodule's own
@api.constrainscheck then flags the row as aself-duplicate at data load. Null the column in pre-migration so the
install can re-set it cleanly.