Skip to content

[18.0][MIG] sale_commission_product_criteria: Migration to version 18.0 and rename to sale_commission_oca_product_criteria#668

Merged
OCA-git-bot merged 21 commits into
OCA:18.0from
Tecnativa:18.0-mig-sale_commission_product_criteria
Apr 6, 2026
Merged

[18.0][MIG] sale_commission_product_criteria: Migration to version 18.0 and rename to sale_commission_oca_product_criteria#668
OCA-git-bot merged 21 commits into
OCA:18.0from
Tecnativa:18.0-mig-sale_commission_product_criteria

Conversation

@david-banon-tecnativa
Copy link
Copy Markdown
Contributor

Migration from 16.0
Replaces #635:

  • Rename to sale_commission_oca_product_criteria
  • Maintains commit history
  • Replaces SQL sarch with ORM as done in [15.0][MIG] sale_commission_product_criteria: Migration to 15.0 #636
  • Squashed bot commits
  • 17.0 and 18.0 migration tasks
  • Updated "commission".action_unarchive() to work on recordsets
  • Updated "account.invoice.line.agent"._compute_amount() to take into account negative commission in refunds
  • Updated tests

cc @CarlosRoca13 @Andrii9090-tecnativa
TT61695 @Tecnativa

Copy link
Copy Markdown

@Andrii9090-tecnativa Andrii9090-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code&functional review 👍

Image

Copy link
Copy Markdown
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Copy Markdown
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ilyasProgrammer and others added 20 commits April 6, 2026 10:19
Currently translated at 100.0% (65 of 65 strings)

Translation: commission-16.0/commission-16.0-sale_commission_product_criteria
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-sale_commission_product_criteria/it/
@david-banon-tecnativa david-banon-tecnativa force-pushed the 18.0-mig-sale_commission_product_criteria branch 2 times, most recently from 81d7ca9 to fa303f6 Compare April 6, 2026 09:10
@david-banon-tecnativa david-banon-tecnativa force-pushed the 18.0-mig-sale_commission_product_criteria branch from fa303f6 to 29243e0 Compare April 6, 2026 09:14
@CarlosRoca13
Copy link
Copy Markdown
Contributor

Thank you so much

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-668-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fdddea4 into OCA:18.0 Apr 6, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 6125ccb. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-mig-sale_commission_product_criteria branch April 6, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.