[16.0] [FIX] sale_commission_agent_restrict: change res_partner form view restriction to _get_view

[rrebollo]

Why this change was made

Root cause: Odoo PR #95729, merged in Odoo 16.0, unified the behavior of the groups attribute across the framework.

Before 16.0

When groups was applied to an XML node in a back-end view, the node was only made invisible — it remained in the view architecture. Third-party modules could reliably:

• Extend the view via xpath inheritance
• Reference those nodes as selectors
• Rely on fields inside them for domain/context evaluation

After 16.0

The groups attribute completely removes the node from the view architecture for users outside the group — matching the long-standing behavior of groups on Python model fields. The PR description states this was done to:

1. Make behavior uniform across Python fields, back-end XML nodes, and front-end nodes
2. Enable view caching without requiring groups in the cache key

The problem this caused

The old XML in sale_commission_agent_restrict used:

<page name='sales_purchases' position="attributes">
    <attribute name="groups">!sale_commission_agent_restrict.group_agent_own_commissions</attribute>
</page>

In Odoo 16.0, those pages are stripped from the arch entirely for agent users. Any third-party module that references those pages (e.g., xpath="//page[@name='sales_purchases']") gets an error because the node no longer exists. Code that worked in 15.0 silently breaks in 16.0.

Why _get_view() is better
The Python override keeps the pages in the arch and sets invisible="1" at runtime. The nodes remain present for:

• Xpath selectors — inheritance from other modules won't break
• Domain evaluation — fields inside the pages remain accessible
• View inheritance — third-party modules can still add content relative to these pages

This is both safer (no breaking changes for dependant modules) and more reliable (explicit control over visibility logic).

One commit cherry-picked from #675

@BinhexTeam T21484

[OCA-git-bot]

Hi @aleuffre,
some modules you are maintaining are being modified, check this out!