[18.0][IMP] dms + dms_file: Upload file and create dms.file directly#472
Open
victoralmau wants to merge 1 commit into
Open
[18.0][IMP] dms + dms_file: Upload file and create dms.file directly#472victoralmau wants to merge 1 commit into
victoralmau wants to merge 1 commit into
Conversation
Contributor
|
Hi @CarlosRoca13, |
victoralmau
changed the title
victoralmau
force-pushed
the
18.0-imp-dms-upload-file
branch
from
ed13767 to
49d963a
Compare
tarteo
approved these changes
May 13, 2026
Member
tarteo
left a comment
tarteo
left a comment
There was a problem hiding this comment.
LGTM like what we discussed in my PR. Can't test it functionality at the moment
Member
|
@victoralmau still draft? |
victoralmau
changed the title
Member
Author
|
Sorry, it's ready to review Ping @CarlosRoca13 |
Member
|
Testing this in runboat, the file uploads, but the thumbnail for images is not created. Can you please check? |
victoralmau
force-pushed
the
18.0-imp-dms-upload-file
branch
from
49d963a to
1ff5f69
Compare
Member
Author
Fixed, can you review again? |
pedrobaeza
reviewed
May 14, 2026
victoralmau
force-pushed
the
18.0-imp-dms-upload-file
branch
2 times, most recently
from
1ff5f69 to
eba492d
Compare
victoralmau
force-pushed
the
18.0-imp-dms-upload-file
branch
from
eba492d to
33cc542
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upload file and create
dms.filedirectlyRelated to #470 (comment)
Please @CarlosRoca13 can you review it?
@Tecnativa